Add note to find_const_ty_from_env
#142927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
compiler-errors
force-pushed
the
note-find-const
branch
from
3410cd8 to
3595d85
Compare
BoxyUwU
reviewed
Jun 23, 2025
compiler-errors
force-pushed
the
note-find-const
branch
from
3595d85 to
df426cf
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 27, 2025
…rors Rollup of 18 pull requests Successful merges: - #137843 (make RefCell unstably const) - #140942 (const-eval: allow constants to refer to mutable/external memory, but reject such constants as patterns) - #142549 (small iter.intersperse.fold() optimization) - #142637 (Remove some glob imports from the type system) - #142647 ([perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation) - #142700 (Remove incorrect comments in `Weak`) - #142927 (Add note to `find_const_ty_from_env`) - #142967 (Fix RwLock::try_write documentation for WouldBlock condition) - #142986 (Port `#[export_name]` to the new attribute parsing infrastructure) - #143001 (Rename run always ) - #143010 (Update `browser-ui-test` version to `0.20.7`) - #143015 (Add `sym::macro_pin` diagnostic item for `core::pin::pin!()`) - #143033 (Expand const-stabilized API links in relnotes) - #143041 (Remove cache for citool) - #143056 (Move an ACE test out of the GCI directory) - #143059 (Fix 1.88 relnotes) - #143067 (Tracking issue number for `iter_macro`) - #143073 (Fix some fixmes that were waiting for let chains) Failed merges: - #143020 (codegen_fn_attrs: make comment more precise) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 27, 2025
Rollup merge of #142927 - compiler-errors:note-find-const, r=BoxyUwU Add note to `find_const_ty_from_env` Add a note to `find_const_ty_from_env` to explain why it has an `unwrap` which "often" causes ICEs. Also, uplift it into the new trait solver. This avoids needing to go through the interner to call this method which is otherwise an inherent method in the compiler. I can remove this part if desired. r? `@boxyuwu`
github-merge-queue bot
pushed a commit
to model-checking/kani
that referenced
this pull request
Jun 30, 2025
Culprit PRs: - rust-lang/rust#142927 - rust-lang/rust#141759 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Jul 4, 2025
…mpiler-errors Rollup of 18 pull requests Successful merges: - rust-lang#137843 (make RefCell unstably const) - rust-lang#140942 (const-eval: allow constants to refer to mutable/external memory, but reject such constants as patterns) - rust-lang#142549 (small iter.intersperse.fold() optimization) - rust-lang#142637 (Remove some glob imports from the type system) - rust-lang#142647 ([perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation) - rust-lang#142700 (Remove incorrect comments in `Weak`) - rust-lang#142927 (Add note to `find_const_ty_from_env`) - rust-lang#142967 (Fix RwLock::try_write documentation for WouldBlock condition) - rust-lang#142986 (Port `#[export_name]` to the new attribute parsing infrastructure) - rust-lang#143001 (Rename run always ) - rust-lang#143010 (Update `browser-ui-test` version to `0.20.7`) - rust-lang#143015 (Add `sym::macro_pin` diagnostic item for `core::pin::pin!()`) - rust-lang#143033 (Expand const-stabilized API links in relnotes) - rust-lang#143041 (Remove cache for citool) - rust-lang#143056 (Move an ACE test out of the GCI directory) - rust-lang#143059 (Fix 1.88 relnotes) - rust-lang#143067 (Tracking issue number for `iter_macro`) - rust-lang#143073 (Fix some fixmes that were waiting for let chains) Failed merges: - rust-lang#143020 (codegen_fn_attrs: make comment more precise) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a note to
find_const_ty_from_envto explain why it has anunwrapwhich "often" causes ICEs.Also, uplift it into the new trait solver. This avoids needing to go through the interner to call this method which is otherwise an inherent method in the compiler. I can remove this part if desired.
r? @BoxyUwU